Commit 40320159 authored Oct 14, 2021 by Qing Wang Committed by Alex Deucher Oct 20, 2021

drm/amdgpu: replace snprintf in show functions with sysfs_emit



show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:427:
WARNING: use scnprintf or sprintf.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 5efacdf0

drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -509,7 +509,7 @@ static ssize_t show_##name(struct device *dev, \
		struct drm_device *ddev = dev_get_drvdata(dev); \
		struct amdgpu_device *adev = drm_to_adev(ddev); \
		\
		return snprintf(buf, PAGE_SIZE, "0x%08x\n", adev->field); \
		return sysfs_emit(buf, "0x%08x\n", adev->field); \
		} \
		static DEVICE_ATTR(name, mode, show_##name, NULL)