Commit 40da8653 authored by Giovanni Cabiddu's avatar Giovanni Cabiddu Committed by Herbert Xu
Browse files

crypto: qat - remove unneeded packed attribute 



Remove packed attribute from structures that do not need to be packed.
These are just used internally and not shared with firmware.

This also fixes a series of warning when compiling the driver with the
flag -Waddress-of-packed-member, similar to the following:

    drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.c:102:28: warning: taking address of packed member 'csr_ops' of class or structure 'adf_hw_device_data' may result in an unaligned pointer value

Signed-off-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reviewed-by: default avatarWojciech Ziemba <wojciech.ziemba@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 70fead3a

drivers/crypto/qat/qat_common/adf_accel_devices.h

+6 −6
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ struct adf_bar { 
	resource_size_t base_addr;

	void __iomem *virt_addr;

	resource_size_t size;

} __packed;

};



struct adf_irq {

	bool enabled;
@@ -52,7 +52,7 @@ struct adf_irq { 
struct adf_accel_msix {

	struct adf_irq *irqs;

	u32 num_entries;

} __packed;

};



struct adf_accel_pci {

	struct pci_dev *pci_dev;
@@ -60,7 +60,7 @@ struct adf_accel_pci { 
	struct adf_bar pci_bars[ADF_PCI_MAX_BARS];

	u8 revid;

	u8 sku;

} __packed;

};



enum dev_state {

	DEV_DOWN = 0,
@@ -100,7 +100,7 @@ struct adf_hw_device_class { 
	const char *name;

	const enum adf_device_type type;

	u32 instances;

} __packed;

};



struct arb_info {

	u32 arb_cfg;
@@ -199,7 +199,7 @@ struct adf_hw_device_data { 
	u8 num_logical_accel;

	u8 num_engines;

	u8 min_iov_compat_ver;

} __packed;

};



/* CSR write macro */

#define ADF_CSR_WR(csr_base, csr_offset, val) \
@@ -266,5 +266,5 @@ struct adf_accel_dev { 
	};

	bool is_vf;

	u32 accel_id;

} __packed;

};

#endif