Commit 4126f99b authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove unused parameter 



All callers of rtl8188eu_xmitframe_complete set the pxmitbuf parameter to
NULL, in which case rtl8188eu_xmitframe_complete allocates another
xmit_buf internally.

Remove the pxmitbuf parameter and resulting dead code.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-6-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c22afb2e

drivers/staging/r8188eu/hal/rtl8188eu_xmit.c

+5 −7
Original line number Diff line number Diff line
@@ -375,11 +375,12 @@ static u32 xmitframe_need_length(struct xmit_frame *pxmitframe) 
	return len;

}



bool rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)

bool rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitpriv)

{

	struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(adapt);

	struct xmit_frame *pxmitframe = NULL;

	struct xmit_frame *pfirstframe = NULL;

	struct xmit_buf *pxmitbuf;



	/*  aggregate variable */

	struct hw_xmit *phwxmit;
@@ -403,12 +404,9 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmit 
	else

		bulksize = USB_FULL_SPEED_BULK_SIZE;



	/*  check xmitbuffer is ok */

	if (!pxmitbuf) {

	pxmitbuf = rtw_alloc_xmitbuf(pxmitpriv);

	if (!pxmitbuf)

		return false;

	}



	/* 3 1. pick up first frame */

	rtw_free_xmitframe(pxmitpriv, pxmitframe);

drivers/staging/r8188eu/hal/usb_ops_linux.c

+1 −1
Original line number Diff line number Diff line
@@ -494,7 +494,7 @@ void rtl8188eu_xmit_tasklet(unsigned long priv) 
		    (adapt->bWritePortCancel))

			break;



		ret = rtl8188eu_xmitframe_complete(adapt, pxmitpriv, NULL);

		ret = rtl8188eu_xmitframe_complete(adapt, pxmitpriv);



		if (!ret)

			break;

drivers/staging/r8188eu/include/rtl8188e_xmit.h

+1 −2
Original line number Diff line number Diff line
@@ -138,7 +138,6 @@ s32 rtl8188eu_xmit_buf_handler(struct adapter *padapter); 
#define hal_xmit_handler rtl8188eu_xmit_buf_handler

void rtl8188eu_xmit_tasklet(unsigned long priv);

bool rtl8188eu_xmitframe_complete(struct adapter *padapter,

				 struct xmit_priv *pxmitpriv,

				 struct xmit_buf *pxmitbuf);

				 struct xmit_priv *pxmitpriv);



#endif /* __RTL8188E_XMIT_H__ */