Commit 42b9fd6e authored by Zhen Lei's avatar Zhen Lei Committed by Marc Kleine-Budde
Browse files

can: at91_can: use DEVICE_ATTR_RW() helper macro 

Use DEVICE_ATTR_RW() helper macro instead of plain DEVICE_ATTR(), which
makes the code a bit shorter and easier to read.

Link: https://lore.kernel.org/r/20210603100233.11877-1-thunder.leizhen@huawei.com


Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent f731707c

drivers/net/can/at91_can.c

+5 −5
Original line number Diff line number Diff line
@@ -1176,7 +1176,7 @@ static const struct net_device_ops at91_netdev_ops = { 
	.ndo_change_mtu = can_change_mtu,

};



static ssize_t at91_sysfs_show_mb0_id(struct device *dev,

static ssize_t mb0_id_show(struct device *dev,

			   struct device_attribute *attr, char *buf)

{

	struct at91_priv *priv = netdev_priv(to_net_dev(dev));
@@ -1187,7 +1187,7 @@ static ssize_t at91_sysfs_show_mb0_id(struct device *dev, 
		return snprintf(buf, PAGE_SIZE, "0x%03x\n", priv->mb0_id);

}



static ssize_t at91_sysfs_set_mb0_id(struct device *dev,

static ssize_t mb0_id_store(struct device *dev,

			    struct device_attribute *attr, const char *buf, size_t count)

{

	struct net_device *ndev = to_net_dev(dev);
@@ -1222,7 +1222,7 @@ static ssize_t at91_sysfs_set_mb0_id(struct device *dev, 
	return ret;

}



static DEVICE_ATTR(mb0_id, 0644, at91_sysfs_show_mb0_id, at91_sysfs_set_mb0_id);

static DEVICE_ATTR_RW(mb0_id);



static struct attribute *at91_sysfs_attrs[] = {

	&dev_attr_mb0_id.attr,