Commit 42c8cd68 authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c 



Remove all of the RT_TRACE logs in the core/rtw_eeprom.c file as they
currently do nothing as they require the code to be modified by
hand in order to be turned on. This obviously has not happened
since the code was merged. Moreover it relies on an unneeded
private log level tracing which overrides the in-kernel public one,
so just remove them as they are unused.

Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/e302fadf18a36d8521456858caff641c0f598731.1617545239.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b365c029

drivers/staging/rtl8723bs/core/rtw_eeprom.c

+22 −34
Original line number Diff line number Diff line
@@ -35,10 +35,9 @@ void shift_out_bits(_adapter *padapter, u16 data, u16 count) 
	u16 x, mask;

_func_enter_;



	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	mask = 0x01 << (count - 1);

	x = rtw_read8(padapter, EE_9346CR);
@@ -48,20 +47,18 @@ _func_enter_; 
		x &= ~_EEDI;

		if (data & mask)

			x |= _EEDI;

		if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

		if (padapter->bSurpriseRemoved == true)

			goto out;

		}



		rtw_write8(padapter, EE_9346CR, (u8)x);

		udelay(CLOCK_RATE);

		up_clk(padapter, &x);

		down_clk(padapter, &x);

		mask = mask >> 1;

	} while (mask);

	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	x &= ~_EEDI;

	rtw_write8(padapter, EE_9346CR, (u8)x);

out:
@@ -72,10 +69,9 @@ u16 shift_in_bits(_adapter *padapter) 
{

	u16 x, d = 0, i;

_func_enter_;

	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	x = rtw_read8(padapter, EE_9346CR);



	x &= ~(_EEDO | _EEDI);
@@ -84,10 +80,9 @@ _func_enter_; 
	for (i = 0; i < 16; i++) {

		d = d << 1;

		up_clk(padapter, &x);

	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



		x = rtw_read8(padapter, EE_9346CR);



		x &= ~(_EEDI);
@@ -122,26 +117,22 @@ void eeprom_clean(_adapter *padapter) 
{

	u16 x;

_func_enter_;

	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	x = rtw_read8(padapter, EE_9346CR);

	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	x &= ~(_EECS | _EEDI);

	rtw_write8(padapter, EE_9346CR, (u8)x);

	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	up_clk(padapter, &x);

		if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	down_clk(padapter, &x);

out:

_func_exit_;
@@ -155,17 +146,14 @@ u16 eeprom_read16(_adapter *padapter, u16 reg) /*ReadEEprom*/ 


_func_enter_;



	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	/* select EEPROM, reset bits, set _EECS*/

	x = rtw_read8(padapter, EE_9346CR);



	if (padapter->bSurpriseRemoved == true) {

		RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true"));

	if (padapter->bSurpriseRemoved == true)

		goto out;

	}



	x &= ~(_EEDI | _EEDO | _EESK | _EEM0);

	x |= _EEM1 | _EECS;