Commit 44dd1414 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Stephen Boyd
Browse files

clk: mediatek: gate: Implement unregister API 



The gate clk type within the MediaTek clk driver library only has a
register function, and no corresponding unregister function. This
means there is no way for its users to properly implement cleanup
and removal.

Add a matching unregister function for the gate type clk.

Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarMiles Chen <miles.chen@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220208124034.414635-5-wenst@chromium.org


Reviewed-by: default avatarChun-Jie Chen <chun-jie.chen@mediatek.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent ee488dc9

drivers/clk/mediatek/clk-gate.c

+35 −0
Original line number Diff line number Diff line
@@ -193,6 +193,21 @@ static struct clk *mtk_clk_register_gate(const char *name, 
	return clk;

}



static void mtk_clk_unregister_gate(struct clk *clk)

{

	struct mtk_clk_gate *cg;

	struct clk_hw *hw;



	hw = __clk_get_hw(clk);

	if (!hw)

		return;



	cg = to_mtk_clk_gate(hw);



	clk_unregister(clk);

	kfree(cg);

}



int mtk_clk_register_gates_with_dev(struct device_node *node,

				    const struct mtk_gate *clks, int num,

				    struct clk_onecell_data *clk_data,
@@ -244,4 +259,24 @@ int mtk_clk_register_gates(struct device_node *node, 
}

EXPORT_SYMBOL_GPL(mtk_clk_register_gates);



void mtk_clk_unregister_gates(const struct mtk_gate *clks, int num,

			      struct clk_onecell_data *clk_data)

{

	int i;



	if (!clk_data)

		return;



	for (i = num; i > 0; i--) {

		const struct mtk_gate *gate = &clks[i - 1];



		if (IS_ERR_OR_NULL(clk_data->clks[gate->id]))

			continue;



		mtk_clk_unregister_gate(clk_data->clks[gate->id]);

		clk_data->clks[gate->id] = ERR_PTR(-ENOENT);

	}

}

EXPORT_SYMBOL_GPL(mtk_clk_unregister_gates);



MODULE_LICENSE("GPL");

drivers/clk/mediatek/clk-gate.h

+3 −0
Original line number Diff line number Diff line
@@ -55,4 +55,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node, 
				    struct clk_onecell_data *clk_data,

				    struct device *dev);



void mtk_clk_unregister_gates(const struct mtk_gate *clks, int num,

			      struct clk_onecell_data *clk_data);



#endif /* __DRV_CLK_GATE_H */