Commit 46d1da21 authored by Johannes Berg's avatar Johannes Berg Committed by Luca Coelho
Browse files

iwlwifi: mvm: don't request SMPS in AP mode 



This is not valid (in the spec) and mac80211 will soon
warn on it, in addition to ignoring it.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20210617100544.d568df20e273.Id45ae38f9b16b3c56fa62266e3e89a1421ea07b0@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent aa899e68

drivers/net/wireless/intel/iwlwifi/mvm/utils.c

+3 −5
Original line number Diff line number Diff line
@@ -621,7 +621,7 @@ void iwl_mvm_update_smps(struct iwl_mvm *mvm, struct ieee80211_vif *vif, 
			 enum ieee80211_smps_mode smps_request)

{

	struct iwl_mvm_vif *mvmvif;

	enum ieee80211_smps_mode smps_mode;

	enum ieee80211_smps_mode smps_mode = IEEE80211_SMPS_AUTOMATIC;

	int i;



	lockdep_assert_held(&mvm->mutex);
@@ -630,10 +630,8 @@ void iwl_mvm_update_smps(struct iwl_mvm *mvm, struct ieee80211_vif *vif, 
	if (num_of_ant(iwl_mvm_get_valid_rx_ant(mvm)) == 1)

		return;



	if (vif->type == NL80211_IFTYPE_AP)

		smps_mode = IEEE80211_SMPS_OFF;

	else

		smps_mode = IEEE80211_SMPS_AUTOMATIC;

	if (vif->type != NL80211_IFTYPE_STATION)

		return;



	mvmvif = iwl_mvm_vif_from_mac80211(vif);

	mvmvif->smps_requests[req_type] = smps_request;