Commit 4987ce82 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: Drop is_64bit_address() and is_mask_bit_support() macros 



is_64bit_address() and is_mask_bit_support() don't provide any useful
abstraction, so drop them.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 2f221349

drivers/pci/msi.c

+2 −2
Original line number Diff line number Diff line
@@ -555,9 +555,9 @@ static int msi_capability_init(struct pci_dev *dev, int nvec) 
		return -ENOMEM;



	entry->msi_attrib.is_msix	= 0;

	entry->msi_attrib.is_64		= is_64bit_address(control);

	entry->msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);

	entry->msi_attrib.entry_nr	= 0;

	entry->msi_attrib.maskbit	= is_mask_bit_support(control);

	entry->msi_attrib.maskbit	= !!(control & PCI_MSI_FLAGS_MASKBIT);

	entry->msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */

	entry->msi_attrib.pos		= dev->msi_cap;

drivers/pci/msi.h

+0 −2
Original line number Diff line number Diff line
@@ -8,8 +8,6 @@ 


#define msi_mask_reg(base, is64bit)	\

	(base + ((is64bit == 1) ? PCI_MSI_MASK_64 : PCI_MSI_MASK_32))

#define is_64bit_address(control)	(!!(control & PCI_MSI_FLAGS_64BIT))

#define is_mask_bit_support(control)	(!!(control & PCI_MSI_FLAGS_MASKBIT))



#define msix_table_offset_reg(base)	(base + PCI_MSIX_TABLE)

#define msix_pba_offset_reg(base)	(base + PCI_MSIX_PBA)