Commit 49aecefc authored by matt mooney's avatar matt mooney Committed by Greg Kroah-Hartman
Browse files

staging: usbip: add break to default case in switch statements 



For consistency, a break statement is added to all default cases that
do not jump to a label.

Signed-off-by: default avatarmatt mooney <mfm@muteddisk.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 5c6499d8

drivers/staging/usbip/stub_rx.c

+1 −1
Original line number Diff line number Diff line
@@ -594,7 +594,7 @@ static void stub_rx_pdu(struct usbip_device *ud) 
		/* NOTREACHED */

		dev_err(dev, "unknown pdu\n");

		usbip_event_add(ud, SDEV_EVENT_ERROR_TCP);

		return;

		break;

	}

}

drivers/staging/usbip/stub_tx.c

+1 −0
Original line number Diff line number Diff line
@@ -91,6 +91,7 @@ void stub_complete(struct urb *urb) 
	default:

		usbip_uinfo("urb completion with non-zero status %d\n",

			    urb->status);

		break;

	}



	/* link a urb to the queue of tx. */

drivers/staging/usbip/usbip_common.c

+10 −3
Original line number Diff line number Diff line
@@ -91,6 +91,7 @@ static void usbip_dump_pipe(unsigned int p) 
		break;

	default:

		printk(KERN_DEBUG "ERR");

		break;

	}



	printk(KERN_DEBUG "\n");
@@ -120,6 +121,7 @@ static void usbip_dump_usb_device(struct usb_device *udev) 
		break;

	default:

		printk(KERN_DEBUG " SPD_ERROR");

		break;

	}



	printk(KERN_DEBUG " tt %p, ttport %d", udev->tt, udev->ttport);
@@ -187,6 +189,7 @@ static void usbip_dump_request_type(__u8 rt) 
		break;

	default:

		printk(KERN_DEBUG "------");

		break;

	}

}
@@ -244,6 +247,7 @@ static void usbip_dump_usb_ctrlrequest(struct usb_ctrlrequest *cmd) 
			break;

		default:

			printk(KERN_DEBUG "REQ(%02X) ", cmd->bRequest);

			break;

		}



		printk(KERN_DEBUG " ");
@@ -342,7 +346,8 @@ void usbip_dump_header(struct usbip_header *pdu) 
		break;

	default:

		/* NOT REACHED */

		usbip_udbg("UNKNOWN\n");

		usbip_udbg("unknown command\n");

		break;

	}

}

EXPORT_SYMBOL_GPL(usbip_dump_header);
@@ -537,9 +542,10 @@ void usbip_pack_pdu(struct usbip_header *pdu, struct urb *urb, int cmd, 
		usbip_pack_ret_submit(pdu, urb, pack);

		break;

	default:

		err("unknown command");

		/* NOT REACHED */

		err("unknown command");

		/* BUG(); */

		break;

	}

}

EXPORT_SYMBOL_GPL(usbip_pack_pdu);
@@ -646,6 +652,7 @@ void usbip_header_correct_endian(struct usbip_header *pdu, int send) 
		/* NOT REACHED */

		err("unknown command in pdu header: %d", cmd);

		/* BUG(); */

		break;

	}

}

EXPORT_SYMBOL_GPL(usbip_header_correct_endian);

drivers/staging/usbip/vhci_hcd.c

+2 −0
Original line number Diff line number Diff line
@@ -320,6 +320,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, 
			usbip_dbg_vhci_rh(" ClearPortFeature: default %x\n",

					  wValue);

			dum->port_status[rhport] &= ~(1 << wValue);

			break;

		}

		break;

	case GetHubDescriptor:
@@ -451,6 +452,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, 
			usbip_dbg_vhci_rh(" SetPortFeature: default %d\n",

					  wValue);

			dum->port_status[rhport] |= (1 << wValue);

			break;

		}

		break;

drivers/staging/usbip/vhci_rx.c

+2 −1
Original line number Diff line number Diff line
@@ -251,6 +251,7 @@ static void vhci_rx_pdu(struct usbip_device *ud) 
		usbip_uerr("unknown pdu %u\n", pdu.base.command);

		usbip_dump_header(&pdu);

		usbip_event_add(ud, VDEV_EVENT_ERROR_TCP);

		break;

	}

}