Commit 4a67fc31 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: DYNAMIC_BB_ANT_DIV is not used 



Remove the DYNAMIC_BB_ANT_DIV capability. It's cleared in one place but
never checked.

DYNAMIC_BB_ANT_DIV is part of podmpriv->SupportAbility, there are no
users that check SupportAbility as a whole and use DYNAMIC_BB_ANT_DIV
implicitly.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220321203031.143486-5-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b06c22b2

drivers/staging/r8188eu/hal/usb_halinit.c

+0 −2
Original line number Diff line number Diff line
@@ -1433,8 +1433,6 @@ void SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariab 
				podmpriv->SupportAbility  &= (~DYNAMIC_BB_DIG);

			} else if (dm_func == 3) {/* disable tx power tracking */

				podmpriv->SupportAbility  &= (~DYNAMIC_RF_CALIBRATION);

			} else if (dm_func == 5) {/* disable antenna diversity */

				podmpriv->SupportAbility  &= (~DYNAMIC_BB_ANT_DIV);

			} else if (dm_func == 6) {/* turn on all dynamic func */

				if (!(podmpriv->SupportAbility  & DYNAMIC_BB_DIG)) {

					struct rtw_dig *pDigTable = &podmpriv->DM_DigTable;

drivers/staging/r8188eu/include/rtw_mlme_ext.h

+0 −2
Original line number Diff line number Diff line
@@ -31,8 +31,6 @@ 
/*  BB ODM section BIT 0-15 */

#define	DYNAMIC_BB_DIG				BIT(0)



#define		DYNAMIC_BB_ANT_DIV			BIT(6)



#define		DYNAMIC_RF_CALIBRATION		BIT(26)



#define		DYNAMIC_ALL_FUNC_ENABLE		0xFFFFFFF