Commit 4aa35a01 authored Apr 16, 2023 by Markus Elfring Committed by Karol Herbst Apr 17, 2023

drm/nouveau/therm: Move an assignment statement behind a null pointer check in two functions

The address of a data structure member was determined before
a corresponding null pointer check in the implementation of
the functions “nvkm_fanpwm_create” and “nvkm_fantog_create”.

Thus avoid the risk for undefined behaviour by moving the assignment
for the data structure member “fan” behind two null pointer checks.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/3d0215dc-74d4-2c42-2eee-7a5fcf62b9f1@web.de

parent 8a89e132

drivers/gpu/drm/nouveau/nvkm/subdev/therm/fanpwm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -98,10 +98,10 @@ nvkm_fanpwm_create(struct nvkm_therm therm, struct dcb_gpio_func func)
		return -ENODEV;

		fan = kzalloc(sizeof(*fan), GFP_KERNEL);
		therm->fan = &fan->base;
		if (!fan)
		return -ENOMEM;

		therm->fan = &fan->base;
		fan->base.type = "PWM";
		fan->base.get = nvkm_fanpwm_get;
		fan->base.set = nvkm_fanpwm_set;

+1 −1

Original line number	Diff line number	Diff line
		@@ -100,10 +100,10 @@ nvkm_fantog_create(struct nvkm_therm therm, struct dcb_gpio_func func)
		}

		fan = kzalloc(sizeof(*fan), GFP_KERNEL);
		therm->fan = &fan->base;
		if (!fan)
		return -ENOMEM;

		therm->fan = &fan->base;
		fan->base.type = "toggle";
		fan->base.get = nvkm_fantog_get;
		fan->base.set = nvkm_fantog_set;