Commit 4b374986 authored by Xie Yongji's avatar Xie Yongji Committed by Eric Biggers
Browse files

aio: Fix incorrect usage of eventfd_signal_allowed() 



We should defer eventfd_signal() to the workqueue when
eventfd_signal_allowed() return false rather than return
true.

Fixes: b542e383 ("eventfd: Make signal recursion protection a task bit")
Signed-off-by: default avatarXie Yongji <xieyongji@bytedance.com>
Link: https://lore.kernel.org/r/20210913111928.98-1-xieyongji@bytedance.com


Reviewed-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
parent 50252e4b

fs/aio.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1760,7 +1760,7 @@ static int aio_poll_wake(struct wait_queue_entry *wait, unsigned mode, int sync, 
		list_del_init(&req->wait.entry);

		list_del_init(&req->wait.entry);

		list_del(&iocb->ki_list);

		list_del(&iocb->ki_list);

		iocb->ki_res.res = mangle_poll(mask);

		iocb->ki_res.res = mangle_poll(mask);

		if (iocb->ki_eventfd && eventfd_signal_allowed()) {

		if (iocb->ki_eventfd && !eventfd_signal_allowed()) {

			iocb = NULL;

			iocb = NULL;

			INIT_WORK(&req->work, aio_poll_put_work);

			INIT_WORK(&req->work, aio_poll_put_work);

			schedule_work(&req->work);

			schedule_work(&req->work);