Commit 4c5b2be1 authored by Florian Fainelli's avatar Florian Fainelli Committed by Marc Zyngier
Browse files

irqchip/gic: Improved warning about incorrect type 



Issue the warning for interrupt lines that have an incorrect interrupt
type and also print the hardware interrupt number to facilitate the
resolution of such problems.

Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220308201117.3870678-1-f.fainelli@gmail.com
parent 0c16e931

drivers/irqchip/irq-gic.c

+4 −2
Original line number Diff line number Diff line
@@ -1115,7 +1115,8 @@ static int gic_irq_domain_translate(struct irq_domain *d, 
		*type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;



		/* Make it clear that broken DTs are... broken */

		WARN_ON(*type == IRQ_TYPE_NONE);

		WARN(*type == IRQ_TYPE_NONE,

		     "HW irq %ld has invalid type\n", *hwirq);

		return 0;

	}
@@ -1132,7 +1133,8 @@ static int gic_irq_domain_translate(struct irq_domain *d, 
		*hwirq = fwspec->param[0];

		*type = fwspec->param[1];



		WARN_ON(*type == IRQ_TYPE_NONE);

		WARN(*type == IRQ_TYPE_NONE,

		     "HW irq %ld has invalid type\n", *hwirq);

		return 0;

	}