Commit 4d88c339 authored Sep 23, 2021 by Sudarsana Reddy Kalluru Committed by David S. Miller Sep 23, 2021

atlantic: Fix issue in the pm resume flow.

After fixing hibernation resume flow, another usecase was found which
should be explicitly handled - resume when device is in "down" state.
Invoke aq_nic_init jointly with aq_nic_start only if ndev was already
up during suspend/hibernate. We still need to perform nic_deinit() if
caller requests for it, to handle the freeze/resume scenarios.

Fixes: 57f780f1 ("atlantic: Fix driver resume flow.")
Signed-off-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fdbccea4

drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -413,13 +413,13 @@ static int atl_resume_common(struct device *dev, bool deep)
		if (deep) {
		/* Reinitialize Nic/Vecs objects */
		aq_nic_deinit(nic, !nic->aq_hw->aq_nic_cfg->wol);
		}

		if (netif_running(nic->ndev)) {
		ret = aq_nic_init(nic);
		if (ret)
		goto err_exit;
		}

		if (netif_running(nic->ndev)) {
		ret = aq_nic_start(nic);
		if (ret)
		goto err_exit;