Commit 4ea1557f authored by Mark Brown's avatar Mark Brown Committed by Wolfram Sang
Browse files

i2c-s3c2410: Convert to devm_kzalloc() 



Saves remembering to call kfree(). There's some kfree()s used by the
resource still, these will be removed in 3.3 using the newly added
devm_request_and_ioremap().

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
parent 979b907f

drivers/i2c/busses/i2c-s3c2410.c

+1 −3
Original line number Diff line number Diff line
@@ -890,7 +890,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) 
		}

	}



	i2c = kzalloc(sizeof(struct s3c24xx_i2c), GFP_KERNEL);

	i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL);

	if (!i2c) {

		dev_err(&pdev->dev, "no memory for state\n");

		return -ENOMEM;
@@ -1035,7 +1035,6 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) 
	clk_put(i2c->clk);



 err_noclk:

	kfree(i2c);

	return ret;

}
@@ -1061,7 +1060,6 @@ static int s3c24xx_i2c_remove(struct platform_device *pdev) 
	release_resource(i2c->ioarea);

	s3c24xx_i2c_dt_gpio_free(i2c);

	kfree(i2c->ioarea);

	kfree(i2c);



	return 0;

}