Commit 4f093a52 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/gem: Warn on trying to use a non-existing framebuffer plane 



Warn if callers of drm_gem_fb_get_obj() try to use a GEM buffer for
a non-existing or unset plane.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Tested-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Acked-by: default avatarChristian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220517113327.26919-6-tzimmermann@suse.de
parent a8d6e127

drivers/gpu/drm/drm_gem_framebuffer_helper.c

+5 −1
Original line number Diff line number Diff line
@@ -53,7 +53,11 @@ MODULE_IMPORT_NS(DMA_BUF); 
struct drm_gem_object *drm_gem_fb_get_obj(struct drm_framebuffer *fb,

					  unsigned int plane)

{

	if (plane >= ARRAY_SIZE(fb->obj))

	struct drm_device *dev = fb->dev;



	if (drm_WARN_ON_ONCE(dev, plane >= ARRAY_SIZE(fb->obj)))

		return NULL;

	else if (drm_WARN_ON_ONCE(dev, !fb->obj[plane]))

		return NULL;



	return fb->obj[plane];