Commit 4f455143 authored by Mark Bloch's avatar Mark Bloch Committed by Saeed Mahameed
Browse files

net/mlx5: Lag, don't use magic numbers for ports 



Instead of using 1 & 2 as the ports numbers use an enum value.

Signed-off-by: default avatarMark Bloch <mbloch@nvidia.com>
Reviewed-by: default avatarMaor Gottlieb <maorg@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 9278287e

drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c

+9 −4
Original line number Diff line number Diff line
@@ -40,6 +40,11 @@ 
#include "lag.h"

#include "mp.h"



enum {

	MLX5_LAG_EGRESS_PORT_1 = 1,

	MLX5_LAG_EGRESS_PORT_2,

};



/* General purpose, use for short periods of time.

 * Beware of lock dependencies (preferably, no locks should be acquired

 * under it).
@@ -193,15 +198,15 @@ static void mlx5_infer_tx_affinity_mapping(struct lag_tracker *tracker, 
	p2en = tracker->netdev_state[MLX5_LAG_P2].tx_enabled &&

	       tracker->netdev_state[MLX5_LAG_P2].link_up;



	*port1 = 1;

	*port2 = 2;

	*port1 = MLX5_LAG_EGRESS_PORT_1;

	*port2 = MLX5_LAG_EGRESS_PORT_2;

	if ((!p1en && !p2en) || (p1en && p2en))

		return;



	if (p1en)

		*port2 = 1;

		*port2 = MLX5_LAG_EGRESS_PORT_1;

	else

		*port1 = 2;

		*port1 = MLX5_LAG_EGRESS_PORT_2;

}



static int _mlx5_modify_lag(struct mlx5_lag *ldev, u8 v2p_port1, u8 v2p_port2)