Unverified Commit 4fbd2978 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: rt5640: clarify expression 



cppcheck warning:

sound/soc/codecs/rt5640.c:1923:61: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT5640_PLL_M_SFT |
                                                            ^

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-9-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1dd9cca7

sound/soc/codecs/rt5640.c

+3 −3
Original line number Diff line number Diff line
@@ -1918,10 +1918,10 @@ static int rt5640_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source, 
		pll_code.n_code, pll_code.k_code);



	snd_soc_component_write(component, RT5640_PLL_CTRL1,

		pll_code.n_code << RT5640_PLL_N_SFT | pll_code.k_code);

		(pll_code.n_code << RT5640_PLL_N_SFT) | pll_code.k_code);

	snd_soc_component_write(component, RT5640_PLL_CTRL2,

		(pll_code.m_bp ? 0 : pll_code.m_code) << RT5640_PLL_M_SFT |

		pll_code.m_bp << RT5640_PLL_M_BP_SFT);

		((pll_code.m_bp ? 0 : pll_code.m_code) << RT5640_PLL_M_SFT) |

		(pll_code.m_bp << RT5640_PLL_M_BP_SFT));



	rt5640->pll_in = freq_in;

	rt5640->pll_out = freq_out;