Commit 50c6dede authored by Lang Yu's avatar Lang Yu Committed by Alex Deucher
Browse files

drm/amdgpu: show both cmd id and name when psp cmd failed 



To cover the corner case that people want to know the ID
of an UNKNOWN CMD.

Suggested-by: default avatarJohn Clements <john.clements@amd.com>
Signed-off-by: default avatarLang Yu <lang.yu@amd.com>
Reviewed-by: default avatarHuang Rui <ray.huang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 3ca001af

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

+4 −4
Original line number Diff line number Diff line
@@ -469,10 +469,10 @@ psp_cmd_submit_buf(struct psp_context *psp, 
	 */

	if (!skip_unsupport && (psp->cmd_buf_mem->resp.status || !timeout) && !ras_intr) {

		if (ucode)

			DRM_WARN("failed to load ucode (%s) ",

				  amdgpu_ucode_name(ucode->ucode_id));

		DRM_WARN("psp gfx command (%s) failed and response status is (0x%X)\n",

			 psp_gfx_cmd_name(psp->cmd_buf_mem->cmd_id),

			DRM_WARN("failed to load ucode %s(0x%X) ",

				  amdgpu_ucode_name(ucode->ucode_id), ucode->ucode_id);

		DRM_WARN("psp gfx command %s(0x%X) failed and response status is (0x%X)\n",

			 psp_gfx_cmd_name(psp->cmd_buf_mem->cmd_id), psp->cmd_buf_mem->cmd_id,

			 psp->cmd_buf_mem->resp.status);

		if (!timeout) {

			ret = -EINVAL;