Commit 52c74d17 authored by Jean Delvare's avatar Jean Delvare Committed by Wolfram Sang
Browse files

i2c: i801: Drop two outdated comments 



* Timeouts are reported even in interrupt mode since commit
  b3b8df97 ("i2c: i801: Use wait_event_timeout to wait for
  interrupts") so drop the comment which claims this only happens in
  polled mode.
* xact does not include the PEC bit, as the driver does not support
  software PEC.

Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Reviewed-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 1d366c2f

drivers/i2c/busses/i2c-i801.c

+0 −5
Original line number Diff line number Diff line
@@ -364,9 +364,6 @@ static int i801_check_post(struct i801_priv *priv, int status) 


	/*

	 * If the SMBus is still busy, we give up

	 * Note: This timeout condition only happens when using polling

	 * transactions.  For interrupt operation, NAK/timeout is indicated by

	 * DEV_ERR.

	 */

	if (unlikely(status < 0)) {

		dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
@@ -475,8 +472,6 @@ static int i801_transaction(struct i801_priv *priv, int xact) 
		return i801_check_post(priv, result ? priv->status : -ETIMEDOUT);

	}



	/* the current contents of SMBHSTCNT can be overwritten, since PEC,

	 * SMBSCMD are passed in xact */

	outb_p(xact | SMBHSTCNT_START, SMBHSTCNT(priv));



	status = i801_wait_intr(priv);