Commit 52f11ec9 authored by Paulo Miguel Almeida's avatar Paulo Miguel Almeida Committed by Greg Kroah-Hartman
Browse files

staging: pi433: remove coding style item from the TODO file 



After several patches sent by the community along the last couple of
years, it's possible to remove the coding style item from the TODO file
in the driver's folder.

This patch addresses the last code formatting inconsistences and remove
the coding style item from the TODO file.

Signed-off-by: default avatarPaulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Link: https://lore.kernel.org/r/YfYdVokxsQ+Adl+T@mail.google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1245e7b6

drivers/staging/pi433/TODO

+0 −1
Original line number Diff line number Diff line 
* coding style does not fully comply with the kernel style guide.

* still TODOs, annotated in the code

* currently the code introduces new IOCTLs. I'm afraid this is a bad idea.

  -> Replace this with another interface, hints are welcome!

drivers/staging/pi433/pi433_if.c

+4 −8
Original line number Diff line number Diff line
@@ -362,8 +362,7 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct pi433_tx_cfg *tx_cfg) 


/*-------------------------------------------------------------------------*/



static int

pi433_start_rx(struct pi433_device *dev)

static int pi433_start_rx(struct pi433_device *dev)

{

	int retval;
@@ -403,8 +402,7 @@ pi433_start_rx(struct pi433_device *dev) 


/*-------------------------------------------------------------------------*/



static int

pi433_receive(void *data)

static int pi433_receive(void *data)

{

	struct pi433_device *dev = data;

	struct spi_device *spi = dev->spi;
@@ -555,8 +553,7 @@ pi433_receive(void *data) 
		return bytes_total;

}



static int

pi433_tx_thread(void *data)

static int pi433_tx_thread(void *data)

{

	struct pi433_device *device = data;

	struct spi_device *spi = device->spi;
@@ -881,8 +878,7 @@ pi433_write(struct file *filp, const char __user *buf, 
	return -EAGAIN;

}



static long

pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)

static long pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)

{

	struct pi433_instance	*instance;

	struct pi433_device	*device;

drivers/staging/pi433/rf69.c

+2 −1
Original line number Diff line number Diff line
@@ -654,7 +654,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag) 
		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_CRC_OK);

	case battery_low:

		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_LOW_BAT);

	default:			 return false;

	default:

		return false;

	}

}