Commit 531f4fd1 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: pcl711: use comedi_request_region() 



Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 814c219a

drivers/staging/comedi/drivers/pcl711.c

+3 −10
Original line number Diff line number Diff line
@@ -451,19 +451,12 @@ static int pcl711_attach(struct comedi_device *dev, struct comedi_devconfig *it) 
	const struct pcl711_board *board = comedi_board(dev);

	struct pcl711_private *devpriv;

	int ret;

	unsigned long iobase;

	unsigned int irq;

	struct comedi_subdevice *s;



	/* claim our I/O space */



	iobase = it->options[0];

	printk(KERN_INFO "comedi%d: pcl711: 0x%04lx ", dev->minor, iobase);

	if (!request_region(iobase, PCL711_SIZE, dev->board_name)) {

		printk("I/O port conflict\n");

		return -EIO;

	}

	dev->iobase = iobase;

	ret = comedi_request_region(dev, it->options[0], PCL711_SIZE);

	if (ret)

		return ret;



	/* grab our IRQ */

	irq = it->options[1];