Commit 53fc25b7 authored by Chenyuan Mi's avatar Chenyuan Mi Committed by Namhyung Kim
Browse files

perf subcmd: Fix missing check for return value of malloc() in add_cmdname() 



The malloc() function may return NULL when it fails,
which may cause null pointer deference in add_cmdname(),
add Null check for return value of malloc().

Found by our static analysis tool.

Signed-off-by: default avatarChenyuan Mi <cymi20@fudan.edu.cn>
Acked-by: default avatarIan Rogers <irogers@google.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/20230614150118.115208-1-cymi20@fudan.edu.cn


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 240de691

tools/lib/subcmd/help.c

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 
void add_cmdname(struct cmdnames *cmds, const char *name, size_t len)

{

	struct cmdname *ent = malloc(sizeof(*ent) + len + 1);

	if (!ent)

		return;



	ent->len = len;

	memcpy(ent->name, name, len);