Commit 540cffba authored by Andrey Gusakov's avatar Andrey Gusakov Committed by Bartosz Golaszewski
Browse files

gpio: pca953x: do not ignore i2c errors 



Per gpio_chip interface, error shall be proparated to the caller.

Attempt to silent diagnostics by returning zero (as written in the
comment) is plain wrong, because the zero return can be interpreted by
the caller as the gpio value.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarAndrey Gusakov <andrey.gusakov@cogentembedded.com>
Signed-off-by: default avatarNikita Yushchenko <nikita.yoush@cogentembedded.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 5816b3e6

drivers/gpio/gpio-pca953x.c

+2 −9
Original line number Diff line number Diff line
@@ -468,15 +468,8 @@ static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off) 
	mutex_lock(&chip->i2c_lock);

	ret = regmap_read(chip->regmap, inreg, &reg_val);

	mutex_unlock(&chip->i2c_lock);

	if (ret < 0) {

		/*

		 * NOTE:

		 * diagnostic already emitted; that's all we should

		 * do unless gpio_*_value_cansleep() calls become different

		 * from their nonsleeping siblings (and report faults).

		 */

		return 0;

	}

	if (ret < 0)

		return ret;



	return !!(reg_val & bit);

}