Commit 54784ffa authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Sebastian Reichel
Browse files

power: supply: max17042: handle fails of reading status register 



Reading status register can fail in the interrupt handler.  In such
case, the regmap_read() will not store anything useful under passed
'val' variable and random stack value will be used to determine type of
interrupt.

Handle the regmap_read() failure to avoid handling interrupt type and
triggering changed power supply event based on random stack value.

Fixes: 39e7213e ("max17042_battery: Support regmap to access device's registers")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 4eef766b

drivers/power/supply/max17042_battery.c

+5 −1
Original line number Diff line number Diff line
@@ -869,8 +869,12 @@ static irqreturn_t max17042_thread_handler(int id, void *dev) 
{

	struct max17042_chip *chip = dev;

	u32 val;

	int ret;



	ret = regmap_read(chip->regmap, MAX17042_STATUS, &val);

	if (ret)

		return IRQ_HANDLED;



	regmap_read(chip->regmap, MAX17042_STATUS, &val);

	if ((val & STATUS_INTR_SOCMIN_BIT) ||

		(val & STATUS_INTR_SOCMAX_BIT)) {

		dev_info(&chip->client->dev, "SOC threshold INTR\n");