Commit 5514f0aa authored Jan 10, 2014 by Yuan Zhong Committed by Jaegeuk Kim Jan 14, 2014

f2fs: remove the needless parameter of f2fs_wait_on_page_writeback



"boo sync" parameter is never referenced in f2fs_wait_on_page_writeback.
We should remove this parameter.

Signed-off-by: Yuan Zhong <yuan.mark.zhong@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>

parent 3bac380c

fs/f2fs/data.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -226,7 +226,7 @@ static void __set_data_blkaddr(struct dnode_of_data *dn, block_t new_addr)
	struct page *node_page = dn->node_page;		struct page *node_page = dn->node_page;
	unsigned int ofs_in_node = dn->ofs_in_node;		unsigned int ofs_in_node = dn->ofs_in_node;

	f2fs_wait_on_page_writeback(node_page, NODE, false);		f2fs_wait_on_page_writeback(node_page, NODE);

	rn = F2FS_NODE(node_page);		rn = F2FS_NODE(node_page);

fs/f2fs/f2fs.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1132,7 +1132,7 @@ void rewrite_node_page(struct f2fs_sb_info , struct page ,
	struct f2fs_summary *, block_t, block_t);		struct f2fs_summary *, block_t, block_t);
	void allocate_data_block(struct f2fs_sb_info , struct page ,		void allocate_data_block(struct f2fs_sb_info , struct page ,
	block_t, block_t , struct f2fs_summary , int);		block_t, block_t , struct f2fs_summary , int);
	void f2fs_wait_on_page_writeback(struct page *, enum page_type, bool);		void f2fs_wait_on_page_writeback(struct page *, enum page_type);
	void write_data_summaries(struct f2fs_sb_info *, block_t);		void write_data_summaries(struct f2fs_sb_info *, block_t);
	void write_node_summaries(struct f2fs_sb_info *, block_t);		void write_node_summaries(struct f2fs_sb_info *, block_t);
	int lookup_journal_in_cursum(struct f2fs_summary_block *,		int lookup_journal_in_cursum(struct f2fs_summary_block *,

fs/f2fs/gc.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -428,7 +428,7 @@ static void gc_node_segment(struct f2fs_sb_info *sbi,

	/* set page dirty and write it */		/* set page dirty and write it */
	if (gc_type == FG_GC) {		if (gc_type == FG_GC) {
	f2fs_wait_on_page_writeback(node_page, NODE, true);		f2fs_wait_on_page_writeback(node_page, NODE);
	set_page_dirty(node_page);		set_page_dirty(node_page);
	} else {		} else {
	if (!PageWriteback(node_page))		if (!PageWriteback(node_page))
	@@ -533,7 +533,7 @@ static void move_data_page(struct inode inode, struct page page, int gc_type)
	} else {		} else {
	struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);		struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);

	f2fs_wait_on_page_writeback(page, DATA, true);		f2fs_wait_on_page_writeback(page, DATA);

	if (clear_page_dirty_for_io(page) &&		if (clear_page_dirty_for_io(page) &&
	S_ISDIR(inode->i_mode)) {		S_ISDIR(inode->i_mode)) {

fs/f2fs/inline.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -106,7 +106,7 @@ static int __f2fs_convert_inline_data(struct inode inode, struct page page)
	set_page_writeback(page);		set_page_writeback(page);
	write_data_page(page, &dn, &new_blk_addr, &fio);		write_data_page(page, &dn, &new_blk_addr, &fio);
	update_extent_cache(new_blk_addr, &dn);		update_extent_cache(new_blk_addr, &dn);
	f2fs_wait_on_page_writeback(page, DATA, true);		f2fs_wait_on_page_writeback(page, DATA);

	/* clear inline data and flag after data writeback */		/* clear inline data and flag after data writeback */
	zero_user_segment(ipage, INLINE_DATA_OFFSET,		zero_user_segment(ipage, INLINE_DATA_OFFSET,

fs/f2fs/inode.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -175,7 +175,7 @@ void update_inode(struct inode inode, struct page node_page)
	{		{
	struct f2fs_inode *ri;		struct f2fs_inode *ri;

	f2fs_wait_on_page_writeback(node_page, NODE, false);		f2fs_wait_on_page_writeback(node_page, NODE);

	ri = F2FS_INODE(node_page);		ri = F2FS_INODE(node_page);