Skip to content
Snippets Groups Projects
Commit 553bc087 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

arcnet: com90xx: add __init attribute


Add __init attribute on a function that is only called from other __init
functions and that is not inlined, at least with gcc version 4.8.4 on an
x86 machine with allyesconfig.  Currently, the function is put in the
.text.unlikely segment.  Declaring it as __init will cause it to be put in
the .init.text and to disappear after initialization.

The result of objdump -x on the function before the change is as follows:

0000000000000000 l     F .text.unlikely 00000000000000bf check_mirror

And after the change it is as follows:

0000000000000000 l     F .init.text	00000000000000ba check_mirror

Done with the help of Coccinelle.  The semantic patch checks for local
static non-init functions that are called from an __init function and are
not called from any other function.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarMichael Grzeschik <mgr@pengutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5df1f77f
No related branches found
No related tags found
No related merge requests found
......@@ -433,7 +433,7 @@ static void __init com90xx_probe(void)
kfree(iomem);
}
static int check_mirror(unsigned long addr, size_t size)
static int __init check_mirror(unsigned long addr, size_t size)
{
void __iomem *p;
int res = -1;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment