Commit 5598e47a authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: set pipe only once 



Set the pipe for reading or writing in usbctrl_vendorreq only once.
There's no need to set it again for every retry.

This patch is an adaptation of commit 889ed8b5 ("staging: rtl8188eu:
set pipe only once") for the new r8188eu driver.

Acked-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Acked-by: default avatarMichael Straube <straube.linux@gmail.com>
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210821164859.4351-10-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f7231a04

drivers/staging/r8188eu/hal/usb_ops_linux.c

+8 −7
Original line number Diff line number Diff line
@@ -40,15 +40,16 @@ static int usbctrl_vendorreq(struct intf_hdl *pintfhdl, u16 value, void *pdata, 
		goto release_mutex;

	}



	while (++vendorreq_times <= MAX_USBCTRL_VENDORREQ_TIMES) {

		memset(pIo_buf, 0, len);



		if (requesttype == REALTEK_USB_VENQT_READ) {

	if (requesttype == REALTEK_USB_VENQT_READ)

		pipe = usb_rcvctrlpipe(udev, 0);/* read_in */

		} else {

	else

		pipe = usb_sndctrlpipe(udev, 0);/* write_out */



	while (++vendorreq_times <= MAX_USBCTRL_VENDORREQ_TIMES) {

		if (requesttype == REALTEK_USB_VENQT_READ)

			memset(pIo_buf, 0, len);

		else

			memcpy(pIo_buf, pdata, len);

		}



		status = usb_control_msg(udev, pipe, REALTEK_USB_VENQT_CMD_REQ,

					 requesttype, value, REALTEK_USB_VENQT_CMD_IDX,