Commit 560ab6c0 authored by Chandan Babu R's avatar Chandan Babu R Committed by Darrick J. Wong
Browse files

xfs: Fix 'set but not used' warning in xfs_bmap_compute_alignments() 



With both CONFIG_XFS_DEBUG and CONFIG_XFS_WARN disabled, the only reference to
local variable "error" in xfs_bmap_compute_alignments() gets eliminated during
pre-processing stage of the compilation process. This causes the compiler to
generate a "set but not used" warning.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarChandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
parent 4533fc63

fs/xfs/libxfs/xfs_bmap.c

+4 −5
Original line number Diff line number Diff line
@@ -3471,7 +3471,6 @@ xfs_bmap_compute_alignments( 
	struct xfs_mount	*mp = args->mp;

	xfs_extlen_t		align = 0; /* minimum allocation alignment */

	int			stripe_align = 0;

	int			error;



	/* stripe alignment for allocation is determined by mount parameters */

	if (mp->m_swidth && (mp->m_flags & XFS_MOUNT_SWALLOC))
@@ -3484,10 +3483,10 @@ xfs_bmap_compute_alignments( 
	else if (ap->datatype & XFS_ALLOC_USERDATA)

		align = xfs_get_extsz_hint(ap->ip);

	if (align) {

		error = xfs_bmap_extsize_align(mp, &ap->got, &ap->prev,

						align, 0, ap->eof, 0, ap->conv,

						&ap->offset, &ap->length);

		ASSERT(!error);

		if (xfs_bmap_extsize_align(mp, &ap->got, &ap->prev, align, 0,

					ap->eof, 0, ap->conv, &ap->offset,

					&ap->length))

			ASSERT(0);

		ASSERT(ap->length);

	}