Commit 58043dbf authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: atomisp: handle errors at sh_css_create_isp_params() 



The succ var tracks memory allocation erros on this function.

Fix it, in order to stop this W=1 Werror in clang:

drivers/staging/media/atomisp/pci/sh_css_params.c:2430:7: error: variable 'succ' set but not used [-Werror,-Wunused-but-set-variable]
        bool succ = true;
             ^

Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 363d50b7

drivers/staging/media/atomisp/pci/sh_css_params.c

+6 −2
Original line number Diff line number Diff line
@@ -2431,7 +2431,7 @@ sh_css_create_isp_params(struct ia_css_stream *stream, 
	unsigned int i;

	struct sh_css_ddr_address_map *ddr_ptrs;

	struct sh_css_ddr_address_map_size *ddr_ptrs_size;

	int err = 0;

	int err;

	size_t params_size;

	struct ia_css_isp_parameters *params =

	kvmalloc(sizeof(struct ia_css_isp_parameters), GFP_KERNEL);
@@ -2473,7 +2473,11 @@ sh_css_create_isp_params(struct ia_css_stream *stream, 
	succ &= (ddr_ptrs->macc_tbl != mmgr_NULL);



	*isp_params_out = params;

	return err;



	if (!succ)

		return -ENOMEM;



	return 0;

}



static bool