Commit 586e8b68 authored by Tapasweni Pathak's avatar Tapasweni Pathak Committed by Greg Kroah-Hartman
Browse files

staging: vt6655: Remove unused code inside switch case 



This patch removes dead code in private_ioctl function and
iwctl_siwmode function, in file ioctl.c.

Inside switch, for a case no code gets executed
after break.

This was detected by smatch.

Signed-off-by: default avatarTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3f8ddea0

drivers/staging/vt6655/ioctl.c

+0 −40
Original line number Diff line number Diff line
@@ -45,7 +45,6 @@ int private_ioctl(struct vnt_private *pDevice, struct ifreq *rq) 
	int		result = 0;

	PWLAN_IE_SSID	pItemSSID;

	SCmdBSSJoin	sJoinCmd;

	SCmdZoneTypeSet	sZoneTypeCmd;

	SCmdScan	sScanCmd;

	SCmdStartAP	sStartAPCmd;

	SCmdSetWEP	sWEPCmd;
@@ -108,45 +107,6 @@ int private_ioctl(struct vnt_private *pDevice, struct ifreq *rq) 
		result = -EOPNOTSUPP;

		break;



		if (copy_from_user(&sZoneTypeCmd, pReq->data, sizeof(SCmdZoneTypeSet))) {

			result = -EFAULT;

			break;

		}



		if (sZoneTypeCmd.bWrite == true) {

			/* write zonetype */

			if (sZoneTypeCmd.ZoneType == ZoneType_USA) {

				/* set to USA */

				pr_debug("set_ZoneType:USA\n");

			} else if (sZoneTypeCmd.ZoneType == ZoneType_Japan) {

				/* set to Japan */

				pr_debug("set_ZoneType:Japan\n");

			} else if (sZoneTypeCmd.ZoneType == ZoneType_Europe) {

				/* set to Europe */

				pr_debug("set_ZoneType:Europe\n");

			}

		} else {

			/* read zonetype */

			unsigned char zonetype = 0;



			if (zonetype == 0x00) {		/* USA */

				sZoneTypeCmd.ZoneType = ZoneType_USA;

			} else if (zonetype == 0x01) {	/* Japan */

				sZoneTypeCmd.ZoneType = ZoneType_Japan;

			} else if (zonetype == 0x02) {	/* Europe */

				sZoneTypeCmd.ZoneType = ZoneType_Europe;

			} else {			/* Unknown ZoneType */

				pr_err("Error:ZoneType[%x] Unknown ???\n", zonetype);

				result = -EFAULT;

				break;

			}

			if (copy_to_user(pReq->data, &sZoneTypeCmd, sizeof(SCmdZoneTypeSet))) {

				result = -EFAULT;

				break;

			}

		}

		break;



	case WLAN_CMD_BSS_JOIN:

		if (pDevice->bMACSuspend == true) {

			if (pDevice->bRadioOff == true)

drivers/staging/vt6655/iwctl.c

+0 −9
Original line number Diff line number Diff line
@@ -464,15 +464,6 @@ int iwctl_siwmode(struct net_device *dev, 
		rc = -EOPNOTSUPP;

		break;



		if (pMgmt->eConfigMode != WMAC_CONFIG_AP) {

			pMgmt->eConfigMode = WMAC_CONFIG_AP;

			if (pDevice->flags & DEVICE_FLAGS_OPENED)

				pDevice->bCommit = true;



		}

		pr_debug("set mode to Access Point\n");

		break;



	case IW_MODE_REPEAT:

		pMgmt->eConfigMode = WMAC_CONFIG_ESS_STA;

		rc = -EOPNOTSUPP;