Commit 5908560a authored by Marco Pagani's avatar Marco Pagani Committed by Oded Gabbay
Browse files

habanalabs: added return value check for hl_fw_dynamic_send_clear_cmd() 



The clang-analyzer reported a warning: "Value stored to 'rc' is never
read".

The return value check for the first hl_fw_dynamic_send_clear_cmd() call
in hl_fw_dynamic_send_protocol_cmd() appears to be missing.

Signed-off-by: default avatarMarco Pagani <marpagan@redhat.com>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 01907ba5

drivers/misc/habanalabs/common/firmware_if.c

+2 −0
Original line number Diff line number Diff line
@@ -1783,6 +1783,8 @@ int hl_fw_dynamic_send_protocol_cmd(struct hl_device *hdev, 


	/* first send clear command to clean former commands */

	rc = hl_fw_dynamic_send_clear_cmd(hdev, fw_loader);

	if (rc)

		return rc;



	/* send the actual command */

	hl_fw_dynamic_send_cmd(hdev, fw_loader, cmd, size);