Commit 59353d70 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: firewire: firedtv-avc.c: replace BUG with proper, error return 



This resolves this smatch error:

drivers/media/firewire/firedtv-avc.c:602 avc_tuner_dsd() error: uninitialized symbol 'pos'.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 935ae6f8

drivers/media/firewire/firedtv-avc.c

+3 −1
Original line number Diff line number Diff line
@@ -597,7 +597,8 @@ int avc_tuner_dsd(struct firedtv *fdtv, 
	case FIREDTV_DVB_C: pos = avc_tuner_dsd_dvb_c(fdtv, p); break;

	case FIREDTV_DVB_T: pos = avc_tuner_dsd_dvb_t(fdtv, p); break;

	default:

		BUG();

		ret = -EIO;

		goto unlock;

	}

	pad_operands(c, pos);
@@ -612,6 +613,7 @@ int avc_tuner_dsd(struct firedtv *fdtv, 
	if (status)

		*status = r->operand[2];

#endif

unlock:

	mutex_unlock(&fdtv->avc_mutex);



	if (ret == 0)