Commit 5993e793 authored by Colin Ian King's avatar Colin Ian King Committed by Alex Deucher
Browse files

drm/amdgpu: Fix masking binary not operator on two mask operations 



Currently the ! operator is incorrectly being used to flip bits on
mask values. Fix this by using the bit-wise ~ operator instead.

Addresses-Coverity: ("Logical vs. bitwise operator")
Fixes: 3c9a7b7d ("drm/amdgpu: update mmhub mgcg&ls for mmhub_v2_3")
Reviewed-by: default avatarHuang Rui <ray.huang@amd.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent eb3b4251

drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c

+2 −2
Original line number Diff line number Diff line
@@ -531,12 +531,12 @@ mmhub_v2_3_update_medium_grain_light_sleep(struct amdgpu_device *adev, 


	if (enable && (adev->cg_flags & AMD_CG_SUPPORT_MC_LS)) {

		data &= ~MM_ATC_L2_CGTT_CLK_CTRL__MGLS_OVERRIDE_MASK;

		data1 &= !(DAGB0_WR_CGTT_CLK_CTRL__LS_OVERRIDE_MASK |

		data1 &= ~(DAGB0_WR_CGTT_CLK_CTRL__LS_OVERRIDE_MASK |

			DAGB0_WR_CGTT_CLK_CTRL__LS_OVERRIDE_WRITE_MASK |

			DAGB0_WR_CGTT_CLK_CTRL__LS_OVERRIDE_READ_MASK |

			DAGB0_WR_CGTT_CLK_CTRL__LS_OVERRIDE_RETURN_MASK |

			DAGB0_WR_CGTT_CLK_CTRL__LS_OVERRIDE_REGISTER_MASK);

		data2 &= !(DAGB0_RD_CGTT_CLK_CTRL__LS_OVERRIDE_MASK |

		data2 &= ~(DAGB0_RD_CGTT_CLK_CTRL__LS_OVERRIDE_MASK |

			DAGB0_RD_CGTT_CLK_CTRL__LS_OVERRIDE_WRITE_MASK |

			DAGB0_RD_CGTT_CLK_CTRL__LS_OVERRIDE_READ_MASK |

			DAGB0_RD_CGTT_CLK_CTRL__LS_OVERRIDE_RETURN_MASK |