Commit 59ba49f9 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: only zero slot memory when reused 



Currently the slot memory is zeroed when it is freed and also when it is
reused, like in hisi_sas_task_prep(). Optimise by avoiding the redundant
zeroing in the free.

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f1dc3584

drivers/scsi/hisi_sas/hisi_sas_main.c

+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ void hisi_sas_slot_task_free(struct hisi_hba *hisi_hba, struct sas_task *task, 
	slot->task = NULL;

	slot->port = NULL;

	hisi_sas_slot_index_free(hisi_hba, slot->idx);

	memset(slot, 0, sizeof(*slot));

	/* slot memory is fully zeroed when it is reused */

}

EXPORT_SYMBOL_GPL(hisi_sas_slot_task_free);