Commit 5b06a716 authored by Ranjan Kumar's avatar Ranjan Kumar Committed by Martin K. Petersen
Browse files

scsi: mpi3mr: Driver unload crashes host when enhanced logging is enabled 



Prevent driver from trying to dereference a NULL pointer in a debug print
while removing a device during driver unload.

Signed-off-by: default avatarRanjan Kumar <ranjan.kumar@broadcom.com>
Signed-off-by: default avatarSreekanth Reddy <sreekanth.reddy@broadcom.com>
Link: https://lore.kernel.org/r/20230228140835.4075-3-ranjan.kumar@broadcom.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 02ca7da2

drivers/scsi/mpi3mr/mpi3mr_transport.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -1552,7 +1552,8 @@ static void mpi3mr_sas_port_remove(struct mpi3mr_ioc *mrioc, u64 sas_address, 




	list_for_each_entry_safe(mr_sas_phy, next_phy,

	list_for_each_entry_safe(mr_sas_phy, next_phy,

	    &mr_sas_port->phy_list, port_siblings) {

	    &mr_sas_port->phy_list, port_siblings) {

		if ((mrioc->logging_level & MPI3_DEBUG_TRANSPORT_INFO))

		if ((!mrioc->stop_drv_processing) &&

		    (mrioc->logging_level & MPI3_DEBUG_TRANSPORT_INFO))

			dev_info(&mr_sas_port->port->dev,

			dev_info(&mr_sas_port->port->dev,

			    "remove: sas_address(0x%016llx), phy(%d)\n",

			    "remove: sas_address(0x%016llx), phy(%d)\n",

			    (unsigned long long)

			    (unsigned long long)