Commit 5b68de67 authored Dec 29, 2022 by Christoph Hellwig Committed by Andrew Morton Jan 18, 2023

fs: remove an outdated comment on mpage_writepages

Patch series "remove generic_writepages"

This series removes generic_writepages by open coding the current
functionality in the three remaining callers.  Besides removing some
code the main benefit is that one of the few remaining ->writepage
callers from outside the core page cache code go away.

This patch (of 6):


mpage_writepages doesn't do any of the page locking itself, so remove and
outdated comment on the locking pattern there.

Link: https://lkml.kernel.org/r/20221229161031.391878-1-hch@lst.de
Link: https://lkml.kernel.org/r/20221229161031.391878-2-hch@lst.de


Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

parent 81e506be

fs/mpage.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -641,14 +641,6 @@ static int __mpage_writepage(struct page page, struct writeback_control wbc,
		*
		* This is a library function, which implements the writepages()
		* address_space_operation.
		*
		* If a page is already under I/O, generic_writepages() skips it, even
		* if it's dirty. This is desirable behaviour for memory-cleaning writeback,
		* but it is INCORRECT for data-integrity system calls such as fsync(). fsync()
		* and msync() need to guarantee that all the data which was dirty at the time
		* the call was made get new I/O started against them. If wbc->sync_mode is
		* WB_SYNC_ALL then we were called for data integrity and we must wait for
		* existing IO to complete.
		*/
		int
		mpage_writepages(struct address_space *mapping,