Commit 5ccf4028 authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman
Browse files

mux: mmio: drop obsolete dependency on COMPILE_TEST 



Since commit 0166dc11 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

As a minor optimization, this also lets us drop of_match_ptr(), as we
now know what it will resolve to, we might as well save cpp some work.

Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarPeter Rosin <peda@axentia.se>
Link: https://lore.kernel.org/r/bc790b4e-1cb4-4ef5-3da8-9d0e6b613bc7@axentia.se


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b866e7e7

drivers/mux/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ config MUX_GPIO 


config MUX_MMIO

	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"

	depends on OF || COMPILE_TEST

	depends on OF

	help

	  MMIO/Regmap register bitfield-controlled Multiplexer controller.

drivers/mux/mmio.c

+1 −1
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ static int mux_mmio_probe(struct platform_device *pdev) 
static struct platform_driver mux_mmio_driver = {

	.driver = {

		.name = "mmio-mux",

		.of_match_table	= of_match_ptr(mux_mmio_dt_ids),

		.of_match_table	= mux_mmio_dt_ids,

	},

	.probe = mux_mmio_probe,

};