Commit 5e90f0f3 authored by Hector Martin's avatar Hector Martin Committed by Kalle Valo
Browse files

brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path 



This avoids leaking memory if brcmf_chip_get_raminfo fails. Note that
the CLM blob is released in the device remove path.

Fixes: 82f93cf4 ("brcmfmac: get chip's default RAM info during PCIe setup")
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHector Martin <marcan@marcan.st>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220131160713.245637-2-marcan@marcan.st
parent e80affde

drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c

+2 −0
Original line number Diff line number Diff line
@@ -1777,6 +1777,8 @@ static void brcmf_pcie_setup(struct device *dev, int ret, 
	ret = brcmf_chip_get_raminfo(devinfo->ci);

	if (ret) {

		brcmf_err(bus, "Failed to get RAM info\n");

		release_firmware(fw);

		brcmf_fw_nvram_free(nvram);

		goto fail;

	}