Commit 5eaa30ae authored by Rui Miguel Silva's avatar Rui Miguel Silva Committed by Mauro Carvalho Chehab
Browse files

media: imx7-media-csi: don't store a floating pointer 



if imx7_csi_try_fmt() fails, cc variable won't be
initialized and csi->cc[sdformat->pad] would be pointing
to a random location.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 1fc79c4b

drivers/staging/media/imx/imx7-media-csi.c

+3 −1
Original line number Diff line number Diff line
@@ -1051,7 +1051,9 @@ static int imx7_csi_set_fmt(struct v4l2_subdev *sd, 
		goto out_unlock;

	}



	imx7_csi_try_fmt(csi, cfg, sdformat, &cc);

	ret = imx7_csi_try_fmt(csi, cfg, sdformat, &cc);

	if (ret < 0)

		goto out_unlock;



	fmt = imx7_csi_get_format(csi, cfg, sdformat->pad, sdformat->which);

	if (!fmt) {