Commit 5f86ecba authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: WF200 has no official SDIO IDs 



Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200
are official SDIO IDs. However, it is not the case, the values used by
WF200 are not official (BTW, the driver rely on the DT rather than on
the SDIO IDs to probe the device).

To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use
raw values.

Reviewed-by: default avatarPali Rohár <pali@kernel.org>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20220216093112.92469-2-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5df60184

drivers/staging/wfx/bus_sdio.c

+2 −3
Original line number Diff line number Diff line
@@ -257,10 +257,9 @@ static void wfx_sdio_remove(struct sdio_func *func) 
	sdio_release_host(func);

}



#define SDIO_VENDOR_ID_SILABS        0x0000

#define SDIO_DEVICE_ID_SILABS_WF200  0x1000

static const struct sdio_device_id wfx_sdio_ids[] = {

	{ SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) },

	/* WF200 does not have official VID/PID */

	{ SDIO_DEVICE(0x0000, 0x1000) },

	{ },

};

MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);