Commit 5faf4153 authored by Balazs Scheidler's avatar Balazs Scheidler Committed by David S. Miller
Browse files

[NETFILTER]: x_tables: add more detail to error message about match/target mask mismatch 



Signed-off-by: default avatarBalazs Scheidler <bazsi@balabit.hu>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 585426fd

net/netfilter/x_tables.c

+5 −4
Original line number Diff line number Diff line
@@ -320,8 +320,8 @@ int xt_check_match(const struct xt_match *match, unsigned short family, 
		return -EINVAL;

	}

	if (match->hooks && (hook_mask & ~match->hooks) != 0) {

		printk("%s_tables: %s match: bad hook_mask %u\n",

		       xt_prefix[family], match->name, hook_mask);

		printk("%s_tables: %s match: bad hook_mask %u/%u\n",

		       xt_prefix[family], match->name, hook_mask, match->hooks);

		return -EINVAL;

	}

	if (match->proto && (match->proto != proto || inv_proto)) {
@@ -410,8 +410,9 @@ int xt_check_target(const struct xt_target *target, unsigned short family, 
		return -EINVAL;

	}

	if (target->hooks && (hook_mask & ~target->hooks) != 0) {

		printk("%s_tables: %s target: bad hook_mask %u\n",

		       xt_prefix[family], target->name, hook_mask);

		printk("%s_tables: %s target: bad hook_mask %u/%u\n",

		       xt_prefix[family], target->name, hook_mask,

		       target->hooks);

		return -EINVAL;

	}

	if (target->proto && (target->proto != proto || inv_proto)) {