Commit 609fded3 authored by Kyle Tso's avatar Kyle Tso Committed by Greg Kroah-Hartman
Browse files

usb: typec: Use sysfs_emit_at when concatenating the string 



The buffer address used in sysfs_emit should be aligned to PAGE_SIZE.
Use sysfs_emit_at instead to offset the buffer.

Fixes: a7cff92f ("usb: typec: USB Power Delivery helpers for ports and partners")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKyle Tso <kyletso@google.com>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230623151036.3955013-4-kyletso@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4b642dc9

drivers/usb/typec/class.c

+2 −2
Original line number Diff line number Diff line
@@ -1288,9 +1288,9 @@ static ssize_t select_usb_power_delivery_show(struct device *dev, 


	for (i = 0; pds[i]; i++) {

		if (pds[i] == port->pd)

			ret += sysfs_emit(buf + ret, "[%s] ", dev_name(&pds[i]->dev));

			ret += sysfs_emit_at(buf, ret, "[%s] ", dev_name(&pds[i]->dev));

		else

			ret += sysfs_emit(buf + ret, "%s ", dev_name(&pds[i]->dev));

			ret += sysfs_emit_at(buf, ret, "%s ", dev_name(&pds[i]->dev));

	}



	buf[ret - 1] = '\n';