Commit 60d03756 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: txpktbuf_bndy does not depend on wifi_spec 



Remove the if clause that sets txpktbuf_bndy. Both branches set the same
value.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220806194304.777059-1-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f13bd29c

drivers/staging/r8188eu/hal/usb_halinit.c

+2 −10
Original line number Diff line number Diff line
@@ -567,7 +567,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) 
{

	u8 value8 = 0;

	u16  value16;

	u8 txpktbuf_bndy;

	u32 status = _SUCCESS;

	int res;

	struct hal_data_8188e *haldata = &Adapter->haldata;
@@ -600,13 +599,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) 
	/*  HW GPIO pin. Before PHY_RFConfig8192C. */

	/*  2010/08/26 MH If Efuse does not support sective suspend then disable the function. */



	if (!pregistrypriv->wifi_spec) {

		txpktbuf_bndy = TX_PAGE_BOUNDARY_88E;

	} else {

		/*  for WMM */

		txpktbuf_bndy = WMM_NORMAL_TX_PAGE_BOUNDARY_88E;

	}



	_InitQueueReservedPage(Adapter);

	_InitQueuePriority(Adapter);

	_InitPageBoundary(Adapter);
@@ -647,9 +639,9 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) 
	if (status == _FAIL)

		goto exit;



	_InitTxBufferBoundary(Adapter, txpktbuf_bndy);

	_InitTxBufferBoundary(Adapter, TX_PAGE_BOUNDARY_88E);



	status =  InitLLTTable(Adapter, txpktbuf_bndy);

	status =  InitLLTTable(Adapter, TX_PAGE_BOUNDARY_88E);

	if (status == _FAIL)

		goto exit;

drivers/staging/r8188eu/include/rtl8188e_hal.h

+0 −6
Original line number Diff line number Diff line
@@ -51,12 +51,6 @@ 


#define TX_PAGE_BOUNDARY_88E (TX_TOTAL_PAGE_NUMBER_88E + 1)



/* Note: For Normal Chip Setting ,modify later */

#define WMM_NORMAL_TX_TOTAL_PAGE_NUMBER			\

	TX_TOTAL_PAGE_NUMBER_88E  /* 0xA9 , 0xb0=>176=>22k */

#define WMM_NORMAL_TX_PAGE_BOUNDARY_88E			\

	(WMM_NORMAL_TX_TOTAL_PAGE_NUMBER + 1) /* 0xA9 */



#include "HalVerDef.h"

#include "hal_com.h"