Commit 6133ed9f authored by Ajay Singh's avatar Ajay Singh Committed by Greg Kroah-Hartman
Browse files

staging: wilc1000: use void return for wilc_hif_pack_sta_param() 



Change the return type from u32 to void for wilc_hif_pack_sta_param() as
its value is not used. Also remove the use of extra pointer as it's not
required now.

Signed-off-by: default avatarAjay Singh <ajay.kathat@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 78c0c4e8

drivers/staging/wilc1000/host_interface.c

+4 −10
Original line number Diff line number Diff line
@@ -1960,12 +1960,9 @@ static void handle_del_beacon(struct work_struct *work) 
	kfree(msg);

}



static u32 wilc_hif_pack_sta_param(u8 *buff, const u8 *mac,

static void wilc_hif_pack_sta_param(u8 *cur_byte, const u8 *mac,

				    struct station_parameters *params)

{

	u8 *cur_byte;



	cur_byte = buff;

	ether_addr_copy(cur_byte, mac);

	cur_byte += ETH_ALEN;
@@ -1990,9 +1987,6 @@ static u32 wilc_hif_pack_sta_param(u8 *buff, const u8 *mac, 
	put_unaligned_le16(params->sta_flags_mask, cur_byte);

	cur_byte += 2;

	put_unaligned_le16(params->sta_flags_set, cur_byte);

	cur_byte += 2;



	return cur_byte - buff;

}



static void handle_del_all_sta(struct work_struct *work)
@@ -3440,7 +3434,7 @@ int wilc_add_station(struct wilc_vif *vif, const u8 *mac, 
		return -ENOMEM;



	cur_byte = wid.val;

	cur_byte += wilc_hif_pack_sta_param(cur_byte, mac, params);

	wilc_hif_pack_sta_param(cur_byte, mac, params);



	result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,

				      wilc_get_vif_idx(vif));
@@ -3532,7 +3526,7 @@ int wilc_edit_station(struct wilc_vif *vif, const u8 *mac, 
		return -ENOMEM;



	cur_byte = wid.val;

	cur_byte += wilc_hif_pack_sta_param(cur_byte, mac, params);

	wilc_hif_pack_sta_param(cur_byte, mac, params);



	result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,

				      wilc_get_vif_idx(vif));