Commit 61479479 authored by Miquel Raynal's avatar Miquel Raynal Committed by Lee Jones
Browse files

mfd: ti_am335x_tscadc: Move the driver structure allocation earlier 



Allocating the driver structure should be done earlier in the probe so
that we can used its members from the beginning.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211015081506.933180-17-miquel.raynal@bootlin.com
parent 8543537c

drivers/mfd/ti_am335x_tscadc.c

+7 −7
Original line number Diff line number Diff line
@@ -125,6 +125,13 @@ static int ti_tscadc_probe(struct platform_device *pdev) 
	int tsc_wires = 0, adc_channels = 0, total_channels;

	int readouts = 0;



	/* Allocate memory for device */

	tscadc = devm_kzalloc(&pdev->dev, sizeof(*tscadc), GFP_KERNEL);

	if (!tscadc)

		return -ENOMEM;



	tscadc->dev = &pdev->dev;



	if (!pdev->dev.of_node) {

		dev_err(&pdev->dev, "Could not find valid DT data.\n");

		return -EINVAL;
@@ -164,13 +171,6 @@ static int ti_tscadc_probe(struct platform_device *pdev) 
		return -EINVAL;

	}



	/* Allocate memory for device */

	tscadc = devm_kzalloc(&pdev->dev, sizeof(*tscadc), GFP_KERNEL);

	if (!tscadc)

		return -ENOMEM;



	tscadc->dev = &pdev->dev;



	err = platform_get_irq(pdev, 0);

	if (err < 0)

		return err;