Commit 6212607e authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: rewrite comparisons to null 



fix the following post-commit hook checkpatch issues:

CHECK: Comparison to NULL could be written "!pwep"
147: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:442:
+			if (pwep == NULL)

CHECK: Comparison to NULL could be written "!skb"
226: FILE: drivers/staging/rtl8723bs/os_dep/recv_linux.c:204:
+	if (skb == NULL)

CHECK: Comparison to NULL could be written "!dvobj"
275: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:398:
+	if (dvobj == NULL)

Suggested-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/92edc9da10838dd99f96a99121343f4ec11b5d90.1617640221.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e1530926

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

+1 −1
Original line number Diff line number Diff line
@@ -439,7 +439,7 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param, 
			wep_key_len = wep_key_len <= 5 ? 5 : 13;

			wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, KeyMaterial);

			pwep = kzalloc(wep_total_len, GFP_KERNEL);

			if (pwep == NULL)

			if (!pwep)

				goto exit;



			pwep->KeyLength = wep_key_len;

drivers/staging/rtl8723bs/os_dep/recv_linux.c

+1 −1
Original line number Diff line number Diff line
@@ -201,7 +201,7 @@ int rtw_recv_indicatepkt(struct adapter *padapter, union recv_frame *precv_frame 
	pfree_recv_queue = &(precvpriv->free_recv_queue);



	skb = precv_frame->u.hdr.pkt;

	if (skb == NULL)

	if (!skb)

		goto _recv_indicatepkt_drop;



	skb->data = precv_frame->u.hdr.rx_data;

drivers/staging/rtl8723bs/os_dep/sdio_intf.c

+1 −1
Original line number Diff line number Diff line
@@ -395,7 +395,7 @@ static int rtw_drv_init( 
	struct dvobj_priv *dvobj;



	dvobj = sdio_dvobj_init(func);

	if (dvobj == NULL)

	if (!dvobj)

		goto exit;



	if1 = rtw_sdio_if1_init(dvobj, id);