Commit 6246f1cc authored by Shiraz Saleem's avatar Shiraz Saleem Committed by Jason Gunthorpe
Browse files

RDMA/irdma: Use list_last_entry/list_first_entry 

Use list_last_entry and list_first_entry instead of using prev and next
pointers.

Link: https://lore.kernel.org/r/20210608211415.680-1-shiraz.saleem@intel.com


Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent ac477efc

drivers/infiniband/hw/irdma/puda.c

+1 −1
Original line number Diff line number Diff line
@@ -1419,7 +1419,7 @@ irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu, 


error:

	while (!list_empty(&pbufl)) {

		buf = (struct irdma_puda_buf *)(pbufl.prev);

		buf = list_last_entry(&pbufl, struct irdma_puda_buf, list);

		list_move(&buf->list, rxlist);

	}

	if (txbuf)

drivers/infiniband/hw/irdma/utils.c

+2 −2
Original line number Diff line number Diff line
@@ -425,7 +425,7 @@ struct irdma_cqp_request *irdma_alloc_and_get_cqp_request(struct irdma_cqp *cqp, 


	spin_lock_irqsave(&cqp->req_lock, flags);

	if (!list_empty(&cqp->cqp_avail_reqs)) {

		cqp_request = list_entry(cqp->cqp_avail_reqs.next,

		cqp_request = list_first_entry(&cqp->cqp_avail_reqs,

					       struct irdma_cqp_request, list);

		list_del_init(&cqp_request->list);

	}