Commit 629132b3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: use safe iterator in xmit_delivery_enabled_frames() 



This loop calls list_del_init(&pxmitframe->list) and "pxmitframe" is the
list iterator so it leads to a forever loop.  We need to use a _safe()
iterator to fix this.

Fixes: 23017c88 ("staging: rtl8188eu: Use list iterators and helpers")
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YL5i5aVMQ3CZ5wuQ@mwanda


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c47bcff9

drivers/staging/rtl8188eu/core/rtw_xmit.c

+3 −6
Original line number Diff line number Diff line
@@ -1912,17 +1912,14 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta) 
void xmit_delivery_enabled_frames(struct adapter *padapter, struct sta_info *psta)

{

	u8 wmmps_ac = 0;

	struct list_head *xmitframe_plist, *xmitframe_phead;

	struct xmit_frame *pxmitframe = NULL;

	struct list_head *xmitframe_phead;

	struct xmit_frame *pxmitframe, *n;

	struct sta_priv *pstapriv = &padapter->stapriv;



	spin_lock_bh(&psta->sleep_q.lock);



	xmitframe_phead = get_list_head(&psta->sleep_q);

	list_for_each(xmitframe_plist, xmitframe_phead) {

		pxmitframe = list_entry(xmitframe_plist, struct xmit_frame,

					list);



	list_for_each_entry_safe(pxmitframe, n, xmitframe_phead, list) {

		switch (pxmitframe->attrib.priority) {

		case 1:

		case 2: