Commit 632ffe09 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: optimise ctx flags layout 



There may be different cost for reeading just one byte or more, so it's
benificial to keep ctx flag bits that we access together in a single
byte. That affected code generation of __io_cq_unlock_post_flush() and
removed one memory load.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/bbe8ca4705704690319d65e45845f9fc9d35f420.1673887636.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 31f084b7

include/linux/io_uring_types.h

+3 −3
Original line number Diff line number Diff line
@@ -196,17 +196,17 @@ struct io_ring_ctx { 
	/* const or read-mostly hot data */

	struct {

		unsigned int		flags;

		unsigned int		compat: 1;

		unsigned int		drain_next: 1;

		unsigned int		restricted: 1;

		unsigned int		off_timeout_used: 1;

		unsigned int		drain_active: 1;

		unsigned int		drain_disabled: 1;

		unsigned int		has_evfd: 1;

		unsigned int		syscall_iopoll: 1;

		/* all CQEs should be posted only by the submitter task */

		unsigned int		task_complete: 1;

		unsigned int		syscall_iopoll: 1;

		unsigned int		poll_activated: 1;

		unsigned int		drain_disabled: 1;

		unsigned int		compat: 1;



		enum task_work_notify_mode	notify_method;

		struct io_rings			*rings;